chore: Make generateRequestId a protected method. #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: He-Pin <hepin1989@gmail.com>
Contributor
|
@He-Pin What's the use-case for this? What are you trying to accomplish? |
Contributor
Author
|
we are building an mcp hub, we are encoding informations inside the sessionId, otherwise we have to change it with a varhandle |
Contributor
|
What kind of info are you encoding? This PR is modifying the request ID generation scheme within a given session, not the session ID itself. As I understand it, the request ID is for request-response reconciliation within a given session. So I guess you need client-related info in the request ID ... is there are reason to use the request ID rather than |
Contributor
Author
|
Oh, I finally recovered my memory, I was think that's the session id, will close and resubmit a new pr. thanks |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Control how the client session ID is generated.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context